Add a test that ensures correct BDF assignment #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
reviewed
Nov 27, 2025
phip1611
requested changes
Nov 27, 2025
Member
phip1611
left a comment
phip1611
left a comment
There was a problem hiding this comment.
Generally great work! Left a few remarks
scholzp
force-pushed
the
bdf_tests
branch
3 times, most recently
from
b23fb51 to
4aac2f1
Compare
Contributor
|
This is great work, can we also add 2 hotplug devices:
|
phip1611
reviewed
Nov 28, 2025
hertrste
reviewed
Nov 28, 2025
Collaborator
hertrste
left a comment
hertrste
left a comment
There was a problem hiding this comment.
We well written test case 👍
phip1611
reviewed
Nov 28, 2025
phip1611
requested changes
Dec 1, 2025
Member
phip1611
left a comment
phip1611
left a comment
There was a problem hiding this comment.
I like the direction into that we are going here - good work! I left a few remarks
scholzp
force-pushed
the
bdf_tests
branch
6 times, most recently
from
8089e2d to
9b27e1b
Compare
tpressure
reviewed
Dec 5, 2025
phip1611
approved these changes
Dec 5, 2025
Member
phip1611
left a comment
phip1611
left a comment
There was a problem hiding this comment.
LGTM but I left a few remarks. I'm already approving.
Member
|
You need to rebase your PR. |
scholzp
force-pushed
the
bdf_tests
branch
3 times, most recently
from
240f603 to
8654c40
Compare
hertrste
approved these changes
Dec 5, 2025
phip1611
requested changes
Dec 5, 2025
Contributor
Author
|
I just added negative tests for:
Both are expected to be blocked and errrored upon by libvirt. |
Member
|
Great work! |
phip1611
requested changes
Dec 15, 2025
scholzp
force-pushed
the
bdf_tests
branch
4 times, most recently
from
fd15760 to
d955b3c
Compare
tpressure
reviewed
Jan 7, 2026
hertrste
reviewed
Jan 7, 2026
hertrste
reviewed
Jan 7, 2026
tpressure
reviewed
Jan 8, 2026
scholzp
force-pushed
the
bdf_tests
branch
2 times, most recently
from
5fe94a9 to
2c91b5d
Compare
phip1611
reviewed
Jan 8, 2026
scholzp
force-pushed
the
bdf_tests
branch
2 times, most recently
from
c5ea19f to
7783a75
Compare
We need to specify slot IDs in the XML from which the VM config for CHV is created. This is in preparation for testing BDF fixing. Signed-off-by: Pascal Scholz <[email protected]> On-behalf-of: SAP [email protected]
When evaluating PCI BDF assignment we need a way to query these information from a test VM. This commit adds a handy way to obtain all BDFs with their assigned devices. Signed-off-by: Pascal Scholz <[email protected]> On-behalf-of: SAP [email protected]
The added tests checks that libvirt and CHV assigned and propagate PCI BDF correctly to the guest's PCI devices. It furthermore ensures, that these assignment stay valid even after live migration. Signed-off-by: Pascal Scholz <[email protected]> On-behalf-of: SAP [email protected]
We test that a VM, after recreation, assignes the same BDFs to it devices, even if we transiently remove a device before shutting the VM down. Signed-off-by: Pascal Scholz <[email protected]> On-behalf-of: SAP [email protected]
We test that the persistent config stores the correct BDF. Signed-off-by: Pascal Scholz <[email protected]> On-behalf-of: SAP [email protected]
We need to test that an invalid BDF results in an error from libvirt and does not crash CHV. Signed-off-by: Pascal Scholz <[email protected]> On-behalf-of: SAP [email protected]
We need a negative test that shows, that adding a function ID when entering a BDF result in libvirt generating a failure and CHV not crashing. Signed-off-by: Pascal Scholz <[email protected]> On-behalf-of: SAP [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test adds checks for verifying correct BDF assignment through libvirt and that CHV respects those assignments, even after live migration. Moreover, this test ensures that BDFs can be freed and reused when de-/attaching devices (might be more of a theoretical feature?).
For further details, see the test description.
Related to https://github.com/cobaltcore-dev/cobaltcore/issues/287.